Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analysis): Returns the resolved query as metadata in the New Relic provider #3715

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

orlando-valdez-ck
Copy link
Contributor

@orlando-valdez-ck orlando-valdez-ck commented Jul 10, 2024

Adds the resolved query in the analysisRun metadata for New Relic metrics.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Orlando Valdez <orlando.valdez@creditkarma.com>
Signed-off-by: Orlando Valdez <orlando.valdez@creditkarma.com>
Signed-off-by: Orlando Valdez <orlando.valdez@creditkarma.com>
Copy link
Contributor

github-actions bot commented Jul 10, 2024

Go Published Test Results

2 171 tests   2 171 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 6501ce0.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (4f1edbe) to head (6501ce0).
Report is 94 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3715      +/-   ##
==========================================
+ Coverage   80.27%   80.29%   +0.02%     
==========================================
  Files         156      156              
  Lines       17964    18021      +57     
==========================================
+ Hits        14420    14470      +50     
- Misses       2631     2637       +6     
- Partials      913      914       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 10, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 28m 38s ⏱️
111 tests 101 ✅  6 💤 4 ❌
450 runs  420 ✅ 24 💤 6 ❌

For more details on these failures, see this check.

Results for commit 6501ce0.

♻️ This comment has been updated with latest results.

orlando-valdez-ck and others added 2 commits July 10, 2024 18:22
Signed-off-by: Orlando Valdez <orlando.valdez@creditkarma.com>
@zachaller zachaller added this to the v1.8 milestone Jul 11, 2024
@zachaller zachaller self-assigned this Jul 11, 2024
@zachaller zachaller merged commit d89abb2 into argoproj:master Jul 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants