Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code coverage for e2e #3740

Merged
merged 18 commits into from
Jul 24, 2024
Merged

chore: code coverage for e2e #3740

merged 18 commits into from
Jul 24, 2024

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jul 23, 2024

This enables test coverage for e2e tests, I moved unit tests and e2e tests into a single workflow called Testing under the testing.yaml workflow.

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@zachaller zachaller changed the title chore: coverage for e2e chore: code coverage for e2e Jul 23, 2024
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (4f1edbe) to head (096e62e).
Report is 104 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3740      +/-   ##
==========================================
- Coverage   80.27%   78.16%   -2.11%     
==========================================
  Files         156      157       +1     
  Lines       17964    22501    +4537     
==========================================
+ Hits        14420    17588    +3168     
- Misses       2631     3999    +1368     
- Partials      913      914       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@argoproj argoproj deleted a comment from github-actions bot Jul 23, 2024
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@argoproj argoproj deleted a comment from github-actions bot Jul 23, 2024
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@argoproj argoproj deleted a comment from github-actions bot Jul 24, 2024
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Copy link

sonarcloud bot commented Jul 24, 2024

@zachaller zachaller marked this pull request as ready for review July 24, 2024 16:21
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit c727a3c into argoproj:master Jul 24, 2024
22 of 23 checks passed
nikoshet pushed a commit to nikoshet/argo-rollouts that referenced this pull request Jul 25, 2024
* first pass at coverage for e2e

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* change folder names

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* only upload latest e2e results

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* change name of step

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix matrix name

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* rename files

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add directory

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* use correct upload name

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* move event file

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* bad move of event_file

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix uncomment

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* only run on testing workflow

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* remove events from go workflow

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* use new download metho

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* remove specific file

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* change workflow name

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* remove double upload

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants