Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metricprovider): credentials to download plugin #3905

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ariadnarouco
Copy link
Contributor

@ariadnarouco ariadnarouco commented Oct 18, 2024

In our company, we have a use case where we need to create a new plugin as a metric provider. For security reasons the plugin needs to be private and cannot be uploaded to a public storage.
Therefore, we have the need to use credentials for downloading the plugin securely.

We have followed k8s secretRef pattern to specify how the credentials are passed.

Additionally, we had an issue with 404 status code. The downloader says that the plugin is downloaded correctly but it’s not true.

Fixes: #3708

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Published E2E Test Results

  4 files    4 suites   3h 14m 38s ⏱️
113 tests 104 ✅  7 💤 2 ❌
454 runs  424 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit 2b091a2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Published Unit Test Results

2 285 tests   2 284 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        1 ❌

For more details on these failures, see this check.

Results for commit 2b091a2.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (53c4f12) to head (ec7937c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3905      +/-   ##
==========================================
+ Coverage   82.66%   82.94%   +0.28%     
==========================================
  Files         163      163              
  Lines       22895    22914      +19     
==========================================
+ Hits        18927    19007      +80     
+ Misses       3092     3032      -60     
+ Partials      876      875       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariadnarouco ariadnarouco changed the title feat(plugin): credentials to download plugin feat(metricprovider): credentials to download plugin Oct 18, 2024
@ariadnarouco ariadnarouco reopened this Nov 4, 2024
Copy link

sonarcloud bot commented Nov 4, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@zachaller zachaller added this to the v1.8 milestone Nov 4, 2024
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Signed-off-by: Ariadna Rouco <ariadna.rouco@gmail.com>
Copy link

sonarcloud bot commented Nov 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be an error message when URL is invalid and the plugin isn't downloaded
2 participants