fix(controller): weighted experiment validation should allow delegating to trafficRouter plugins #3909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though weighted experiment calls are correctly delegated to Traffic Router plugins, the validation is currently not allowing to register a TrafficRouting plugin when weighted experiments are present.
It seems that this validation was added before plugin architecture supported
additionalDestinations
, so it made sense then. Ideally a plugin would have a way to announce it's capabilities, but given right now API does not have anything suitable for that - this PR provides a simple way to unblock using plugins that support weighted experiments.Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.