Skip to content

Commit

Permalink
fix: handle nil ParseableType from GVKParser
Browse files Browse the repository at this point in the history
Signed-off-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
  • Loading branch information
leoluz committed May 9, 2024
1 parent 86a3688 commit 32c718e
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pkg/diff/diff.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,10 @@ func removeWebhookMutation(predictedLive, live *unstructured.Unstructured, gvkPa
}
gvk := predictedLive.GetObjectKind().GroupVersionKind()
pt := gvkParser.Type(gvk)
if pt == nil {
return nil, fmt.Errorf("unable to resolve parseableType for gvk: %s", gvk)
}

typedPredictedLive, err := pt.FromUnstructured(predictedLive.Object)
if err != nil {
return nil, fmt.Errorf("error converting predicted live state from unstructured to %s: %w", gvk, err)
Expand Down Expand Up @@ -316,6 +320,9 @@ func structuredMergeDiff(p *SMDParams) (*DiffResult, error) {

gvk := p.config.GetObjectKind().GroupVersionKind()
pt := gescheme.ResolveParseableType(gvk, p.gvkParser)
if pt == nil {
return nil, fmt.Errorf("unable to resolve parseableType for gvk: %s", gvk)
}

// Build typed value from live and config unstructures
tvLive, err := pt.FromUnstructured(p.live.Object)
Expand Down

0 comments on commit 32c718e

Please sign in to comment.