Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In 'ManageResources' and 'runResourceCommand', temporary files written to '/dev/shm' may not be cleaned up, in rare cases #568

Closed
jgwest opened this issue Apr 11, 2024 · 0 comments · Fixed by #569
Closed

In 'ManageResources' and 'runResourceCommand', temporary files written to '/dev/shm' may not be cleaned up, in rare cases #568

jgwest opened this issue Apr 11, 2024 · 0 comments · Fixed by #569
Assignees
@jgwest
Labels
bug Something isn't working

Comments

@jgwest
Copy link
Member

jgwest commented Apr 11, 2024 •
edited
Loading

We've had user reports of /dev/shm running out of space due to temporary files left hanging around within the application-container of Argo CD. Within Argo CD's application-controller, the references to /dev/shm are limited to gitops-engine's TempDir in pkg/utils/io.

I've thus been auditing gitops-engine's use of /dev/shm, and discovered there are a couple (rare) cases where the temporary files that are created in /dev/shm would not be cleaned up.

#569 has been raised to fix the issue.
@jgwest jgwest self-assigned this Apr 11, 2024
@jgwest jgwest added the bug Something isn't working label Apr 11, 2024
@jgwest jgwest changed the title In 'ManageResources' and 'runResourceCommand', temporay files written to '/dev/'shm may not be cleaned up, in rare cases In 'ManageResources' and 'runResourceCommand', temporary files written to '/dev/shm' may not be cleaned up, in rare cases Apr 11, 2024
jgwest added a commit to jgwest/gitops-engine that referenced this issue Apr 11, 2024
@jgwest
fix: fix temporary files written to '/dev/shm' not cleaned up (argopr…
e6aa81d 
…oj#568)

Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest jgwest mentioned this issue Apr 11, 2024
Merged
jannfis pushed a commit that referenced this issue Apr 11, 2024
@jgwest
fix: fix temporary files written to '/dev/shm' not cleaned up (#568) (#…
1ade3a1 
…569)

Signed-off-by: Jonathan West <jonwest@redhat.com>
@jgwest jgwest mentioned this issue May 4, 2024
Open
@jgwest jgwest mentioned this issue Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgwest jgwest

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: temporary files written to '/dev/shm' not cleaned up (#568) jgwest/gitops-engine
1 participant
@jgwest