feat: Add ability to hide certain annotations on secret resources #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
|
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍
|
pasha-codefresh
requested changes
Jun 30, 2024
|
Hi @pasha-codefresh, sorry for the nudge 👉 😅. Did you get a chance to review it again? |
|
@svghadi sorry, had urgent work to do, i will review it tomorrow |
|
Hey @pasha-codefresh, were you able to review it again by any chance? thanks in advance. |
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
svghadi
force-pushed
the
hide-annotations
branch
from
d98e37a
to
2dd3ac2
Compare
jsoref
reviewed
Sep 19, 2024
pkg/diff/diff.go
Outdated
| @@ -969,10 +969,10 @@ func CreateTwoWayMergePatch(orig, new, dataStruct interface{}) ([]byte, bool, er | |||
| return patch, string(patch) != "{}", nil | |||
| } | |||
|
|
|||
| // HideSecretData replaces secret data values in specified target, live secrets and in last applied configuration of live secret with stars. Also preserves differences between | |||
| // HideSecretData replaces secret data & optional annotations values in specified target, live secrets and in last applied configuration of live secret with stars. Also preserves differences between | |||
There was a problem hiding this comment.
I kinda object to Hide as a verb, this appears to be closer to Mask than Hide.
That appears to be a preexisting condition, but if I inherited this code, I'd want to change it.
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
agaudreault
requested changes
Sep 23, 2024
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
pasha-codefresh
requested changes
Oct 23, 2024
pasha-codefresh
requested changes
Oct 23, 2024
pasha-codefresh
requested changes
Oct 23, 2024
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
|
|
Taking one more day for manual testing, but overall LGTM to me |
pasha-codefresh
approved these changes
Oct 29, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to argoproj/argo-cd#15693.
This PR implements core logic from argoproj/argo-cd#hide-annotations.md proposal to hide annotations on secret resources.
This change will be integrated with Argo CD via argoproj/argo-cd#18216.
Integration results:
mask-annotations.mov