Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ExternalSecret to sync wave task #611

Closed

Conversation

ckav370
Copy link

@ckav370 ckav370 commented Jul 16, 2024

I want to be able to use a preSync hook to run some database migrations. This has been working fine, until such a time as updating the container secrets which are using the External Secret Operator and CRD to create a k8s secret which the job created by the preSync hook creates mounts.

As per this Github issue #9891, the recommended approach is to use Argo sync waves. However ExternalSecret is not included in one of the predefined kinds and therefore cannot be part of a different "wave" meaning that any secrets defined by ExternalSecrets cannot be synced before the preSync hook as part of the pre Sync wave.

This would allow the ExternalSecret to have an annotation such as the following

argocd.argoproj.io/sync-wave: "-2"

And a preSync hook to have a greater weighted sync wave such as

argocd.argoproj.io/sync-wave: "-1"

And all other resources which are part of the deployment would default to weight of 0 without the need for an annotation

Signed-off-by: ckav370 <cblain370@gmail.com>
@ckav370 ckav370 force-pushed the ckav370/add-external-secret-sync-wave branch from 7bee161 to 2d991d2 Compare July 16, 2024 12:06
Signed-off-by: ckav370 <cblain370@gmail.com>
@ckav370 ckav370 force-pushed the ckav370/add-external-secret-sync-wave branch from cc65bfd to 170ad21 Compare July 16, 2024 12:17
Signed-off-by: ckav370 <cblain370@gmail.com>
Signed-off-by: ckav370 <cblain370@gmail.com>
…-wave' into ckav370/add-external-secret-sync-wave
@ckav370 ckav370 closed this Jul 16, 2024
@ckav370 ckav370 deleted the ckav370/add-external-secret-sync-wave branch July 16, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants