Skip to content

Commit

Permalink
IO getters for RecursiveSnark (#312)
Browse files Browse the repository at this point in the history
* IO getters for `RecursiveSnark`

* Nova IO getters
  • Loading branch information
gabriel-barrett authored Feb 10, 2024
1 parent 42a9f16 commit e1783c8
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,16 @@ where
})
}

/// Inputs of the primary circuits
pub fn z0_primary(&self) -> &Vec<E1::Scalar> {
&self.z0_primary
}

/// Outputs of the primary circuits
pub fn zi_primary(&self) -> &Vec<E1::Scalar> {
&self.zi_primary
}

/// Create a new `RecursiveSNARK` (or updates the provided `RecursiveSNARK`)
/// by executing a step of the incremental computation
#[tracing::instrument(skip_all, name = "nova::RecursiveSNARK::prove_step")]
Expand Down
10 changes: 10 additions & 0 deletions src/supernova/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,16 @@ where
})
}

/// Inputs of the primary circuits
pub fn z0_primary(&self) -> &Vec<E1::Scalar> {
&self.z0_primary
}

/// Outputs of the primary circuits
pub fn zi_primary(&self) -> &Vec<E1::Scalar> {
&self.zi_primary
}

/// executing a step of the incremental computation
#[allow(clippy::too_many_arguments)]
#[tracing::instrument(skip_all, name = "supernova::RecursiveSNARK::prove_step")]
Expand Down

1 comment on commit e1783c8

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Table of Contents

Overview

This benchmark report shows the Arecibo GPU benchmarks.
NVIDIA L4
Intel(R) Xeon(R) CPU @ 2.20GHz
32 vCPUs
125 GB RAM
Workflow run: https://github.com/lurk-lab/arecibo/actions/runs/7851753876

Benchmark Results

RecursiveSNARK-NIVC-2

ref=42a9f16 ref=e1783c8
Prove-NumCons-6540 53.48 ms (✅ 1.00x) 53.34 ms (✅ 1.00x faster)
Verify-NumCons-6540 33.09 ms (✅ 1.00x) 33.18 ms (✅ 1.00x slower)
Prove-NumCons-1028888 365.46 ms (✅ 1.00x) 347.72 ms (✅ 1.05x faster)
Verify-NumCons-1028888 276.10 ms (✅ 1.00x) 260.03 ms (✅ 1.06x faster)

CompressedSNARK-NIVC-Commitments-2

ref=42a9f16 ref=e1783c8
Prove-NumCons-6540 14.13 s (✅ 1.00x) 14.15 s (✅ 1.00x slower)
Verify-NumCons-6540 78.44 ms (✅ 1.00x) 79.13 ms (✅ 1.01x slower)
Prove-NumCons-1028888 111.72 s (✅ 1.00x) 111.48 s (✅ 1.00x faster)
Verify-NumCons-1028888 776.25 ms (✅ 1.00x) 780.37 ms (✅ 1.01x slower)

Made with criterion-table

Please sign in to comment.