Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust handling of public parameters #15

Open
larskuhtz opened this issue Sep 14, 2024 · 0 comments
Open

More robust handling of public parameters #15

larskuhtz opened this issue Sep 14, 2024 · 0 comments

Comments

@larskuhtz
Copy link
Contributor

I think the following code snipped it problematic, since it rules out programs with public parameters that are shorter than 32 bytes.

    let public_inputs: String = if bit_length > 256 {
        // The user has provided the committed values rather than the digest!
        // Let's reproduce the digest using the committed values

It think, the best solution would be to provide a separate API function for the (probably common) use case when the actual public parameters are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant