-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve and update dependencies #104
Conversation
- Replaced standard HashMap with hashbrown's HashMap in `execute.rs` for optimization. - Modified `prove` method in `StarkMachine` to take a new additional argument `opts` of type `SphinxCoreOpts`. - Updated several dependencies branch references in `Cargo.toml` including changing `sphinx-core` to use `plonk-rebased` branch. Companion PR of argumentcomputer/sphinx#72
Did you run the benchmarks? I recall not seeing any improvements from using this lib on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, HashMap
in execute.rs
is not used in any perf-sensitive part of the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine but CI is failing due to an outdated token, we just need to wait a bit for @samuelburnham
@arthurpaulino this use of the |
execute.rs
for optimization.prove
method inStarkMachine
to take a new additional argumentopts
of typeSphinxCoreOpts
.Cargo.toml
including changingsphinx-core
to useplonk-rebased
branch.Companion PR of argumentcomputer/sphinx#72
Note
CI failure is expected, CI should be re-run once argumentcomputer/sphinx#72 is merged.