chore: enhance ReservedTag::to_field
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
force-pushed
the
ap/strum
branch
from
dfbc08a
to
a6bdc72
Compare
arthurpaulino
force-pushed
the
ap/strum
branch
from
a6bdc72
to
f1b3d47
Compare
Make it so that `Tag::to_field` doesn't need to skip reserved tags by pushing reserved tags to start from where tags end.
arthurpaulino
force-pushed
the
ap/strum
branch
from
f1b3d47
to
261f509
Compare
wwared
approved these changes
Sep 24, 2024
wwared
reviewed
Sep 24, 2024
| #[test] | ||
| fn test_strum() { | ||
| assert_eq!(14, Tag::COUNT); | ||
| assert_eq!(Tag::COUNT, Tag::iter().count()); |
There was a problem hiding this comment.
nit: This specific assert seems unnecessary (but we can leave it for sanity checking strum)
|
|
||
| #[test] | ||
| fn test_strum() { | ||
| assert_eq!(2, ReservedTag::iter().count()); |
There was a problem hiding this comment.
nit: I feel like it would make more sense to derive EnumCount for ReservedTag and use ReservedTag::COUNT. But I can also see keeping just EnumIter since I think we would only use ReservedTag::COUNT in this particular test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so that
Tag::to_fielddoesn't need to skip reserved tags by pushing reserved tags to start from where tags end.