feat: Forward ports #164
Open
feat: Forward ports #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
forward_ports_44
branch
3 times, most recently
from
604ca3d
to
424f6a1
Compare
Co-authored-by: Tamir Hemo <tamir@succinct.xyz> Co-authored-by: Chris Tian <chris@succinct.xyz>
adr1anh
previously approved these changes
Sep 2, 2024
|
Except 210423a (porting succinctlabs/sp1#1099) does create a test failure ( |
wwared
force-pushed
the
forward_ports_44
branch
2 times, most recently
from
ba8068d
to
3347156
Compare
wwared
reviewed
Sep 9, 2024
The two columns in `AbsorbWorkspace` introduced in `210423a5403b25319da2b60dce78e0d9d107d0aa` seemed to expose some underlying issue which made the gnark circuit fail to accept a proof even though the execution did not trigger any `TRAP`s. It seems like the placement of these two columns in this struct were the reason why it was failing, possibly some unfortunate interaction of `AlignedBorrow`, Rust unions, or something else. The issue exposed itself as a gnark constraint failure, and the specific constraint that was failing was the one responsible for verifying the constraints for the `Multi` chip. The `Multi` chip can have either a `FriFoldChip` or a `Poseidon2WideChip` for each row. This might help explain why this change was leading to constraint failures.
wwared
force-pushed
the
forward_ports_44
branch
from
794c2aa
to
9789a2b
Compare
This refactor moves the `PublicValues` struct into the corresponding `WithEvents` impls for each chip that needs access to it explicitly.
wwared
force-pushed
the
forward_ports_44
branch
from
1d04242
to
0174a5f
Compare
huitseeker
force-pushed
the
forward_ports_44
branch
3 times, most recently
from
527111d
to
a6e2d46
Compare
- Replaced `Field` trait with `Sync` in various modules for the `Poseidon2WideChip` implementation and friends, thereby updating associated dependencies. - In the `fri_fold` module, updated functions and methods to support the new interface and constraints with revised struct and replaced `Field` trait with `Sync`,
- Renamed package from `sp1-recursion-gnark-cli` to `sphinx-recursion-gnark-cli` - Updated dependency from `sp1-recursion-gnark-ffi` to `sphinx-recursion-gnark-ffi` - Included macOS-specific linking for CoreFoundation and Security frameworks in gnark-ffi package
- Enhanced error handling across three critical go files in recursion/gnark-ffi, ensuring each function returns an error along with its intended output if any error occurs. - Improved `randomPolynomial` function to return an error along with the polynomial and added necessary error checks. - Improved safety by adding error handling for `SetString` and `SetRandom` operations, the program will now terminate in case of any error. - Added error handling for critical function calls, such as `os.MkdirAll` and `vk.ExportSolidity` in build.go. - Strengthened guard against unexpected panic conditions in `prove.go` by enabling error handling for `ReadFrom` methods for the R1CS, proving key, and verifier key.
- Added a step in the GitHub workflow to install the `sphinx-recursion-gnark-cli` for integration testing. - Prepared for future testing capabilities by adding a note for `test-plonk-bn254`, pending CLI readiness.
- Introduced cross-platform support for the Go build command in the gnark-ffi's build.rs script. - Enhanced detection of the current operating system to set the appropriate GOOS environment variable.
huitseeker
force-pushed
the
forward_ports_44
branch
from
a6e2d46
to
76596b1
Compare
- Replaced static type `F` with generic type parameter `T` across multiple methods in `MultiChip` struct, - this should lead to better compatibility with upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the following upstream PRs:
sp1-proversuccinctlabs/sp1#1042BuildArgstobuild_programsuccinctlabs/sp1#995sp1-helperworkspace build succinctlabs/sp1#1119This completes parity with upstream's v1.0.0-rc.1