Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update for latest Sphinx changes #211

Closed
wants to merge 7 commits into from
Closed

Conversation

wwared
Copy link
Member

@wwared wwared commented Sep 9, 2024

Companion PR for argumentcomputer/sphinx#164
Companion PR for argumentcomputer/sphinx#186

@wwared
Copy link
Member Author

wwared commented Sep 10, 2024

Even though the tests pass, trying to generate the full SNARK e2e proof (with RUST_BACKTRACE=1 SP1_DEBUG=true RUST_LOG=debug cargo nextest run --verbose --release --features aptos --run-ignored all --package aptos-lc --no-capture -E 'test(test_snark_prove_epoch_change)') fails with:

2024-09-10T02:41:44.348368Z DEBUG compress: Recursive proof layer size: 2
2024-09-10T02:41:47.725274Z  INFO compress: close time.busy=117s time.idle=4.12µs
thread 'inclusion::test::test_snark_prove_inclusion' panicked at light-client/src/inclusion.rs:340:66:
called `Result::unwrap()` on an `Err` value: Runtime error: TRAP encountered: Backtrace:
   0: sphinx_recursion_compiler::ir::builder::TracedVec<T>::trace_push
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/compiler/src/ir/builder.rs:58:39
   1: sphinx_recursion_compiler::ir::builder::Builder<C>::trace_push
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/compiler/src/ir/builder.rs:175:9
      <sphinx_recursion_compiler::ir::types::Felt<<C as sphinx_recursion_compiler::ir::Config>::F> as sphinx_recursion_compiler::ir::var::Variable<C>>::assert_eq
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/compiler/src/ir/types.rs:777:25
   2: sphinx_recursion_compiler::ir::builder::Builder<C>::assert_eq
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/compiler/src/ir/builder.rs:206:9
      sphinx_recursion_compiler::ir::builder::Builder<C>::assert_felt_eq
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/compiler/src/ir/builder.rs:242:14
      sphinx_recursion_program::machine::utils::assert_complete
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/program/src/machine/utils.rs:80:17
   3: sphinx_recursion_program::machine::compress::SphinxCompressVerifier<C,SC,A>::verify::{{closure}}
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/program/src/machine/compress.rs:590:17
      sphinx_recursion_compiler::ir::builder::IfBuilder<C>::then_or_else
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/compiler/src/ir/builder.rs:614:9
      sphinx_recursion_program::machine::compress::SphinxCompressVerifier<C,SC,A>::verify
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/program/src/machine/compress.rs:587:9
      sphinx_recursion_program::machine::compress::SphinxCompressVerifier<sphinx_recursion_compiler::asm::config::AsmConfig<p3_baby_bear::baby_bear::BabyBear,p3_field::extension::binomial_extension::BinomialExtensionField<p3_b
aby_bear::baby_bear::BabyBear,4_usize>>,sphinx_core::utils::prove::baby_bear_poseidon2::BabyBearPoseidon2,A>::build
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/recursion/program/src/machine/compress.rs:91:9
   4: sphinx_prover::SphinxProver<C>::new
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/prover/src/lib.rs:166:32
   5: sphinx_sdk::provers::local::LocalProver<C>::new
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/sdk/src/provers/local.rs:21:22
      sphinx_sdk::ProverClient::new
             at /home/w/.cargo/git/checkouts/sphinx-fc5af6273e2696cb/ee510ca/sdk/src/lib.rs:75:34

It looks like there's a non-zero cumulative sum here? Not sure

@wwared wwared force-pushed the update-for-fp44 branch 2 times, most recently from 31eb0ad to 2e93f52 Compare October 21, 2024 13:24
@wwared wwared changed the title chore: Update for Sphinx v1.0.0-rc.1 chore: Update for latest Sphinx changes Oct 21, 2024
@wwared
Copy link
Member Author

wwared commented Oct 29, 2024

Superseded by #308

@wwared wwared closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant