feat: Final docs pass #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add security.md page - Update all the bench commands - Combine all the benchmarking variables (RUSTFLAGS etc) to be equal - Pin toolchain to nightly-2024-05-31 (current nightly is unfortunately not working for the LC) - Minor fixes to proof_server.rs - General minor changes over all the docs
wwared
commented
Jun 24, 2024
tchataigner
reviewed
Jun 24, 2024
Co-authored-by: tchataigner <tom.chataigner@yahoo.fr>
storojs72
previously approved these changes
Jun 24, 2024
Co-authored-by: Artem Storozhuk <storojs72@gmail.com>
Signed-off-by: Thomas Chataigner <tom.chataigner@yahoo.fr>
Remove RUST_LOG from the proof_server bench. The plonky3 and other logs cause a loss of parallelism due to the stdout mutex, leading to a performance regression with it on.
tchataigner
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tag-release.ymlworkflow (further fixes such as argumentcomputer/sphinx@b3d62f0 coming in a follow-up PR)This PR is probably enough to close #14