Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One x-editable package to rule them all #1

Open
dandv opened this issue Dec 17, 2014 · 3 comments
Open

One x-editable package to rule them all #1

dandv opened this issue Dec 17, 2014 · 3 comments

Comments

@dandv
Copy link

dandv commented Dec 17, 2014

Hey @banglashi, @arillo, @nate-strauser, @davidworkman9,

I've noticed a few versions of x-editable wrappers on Atmosphere:
https://atmospherejs.com/arillo/meteor-x-editable
https://atmospherejs.com/natestrauser/x-editable-bootstrap
https://atmospherejs.com/workman/meteor-editable

Based on the Atmosphere pages, Nate's seems to be the better maintained version.

We have a bigger problem, however - the original x-editable is no longer being actively maintained. Otherwise, I'd be happy to submit my Meteor integration PR to the author, and have direct support for Meteor in their repo, as we'll soon have from the Bootstrap guys.

How can we work together on this?

@nate-strauser
Copy link

i'm ok with whatever we come up with here

this package has been my biggest headache of all my packages, i've been suggesting that people use meteor-editable (which is not a wrapper at all, but a meteor targeted rewrite) instead as x-editable just doesnt work very well with meteor apps

@davidworkman9
Copy link

meteor-editable has been somewhat neglected. It works, for all of my use-cases (I use it currently in production) but is far from a complete rewrite.

I've put out another package called x-editable-reactive-template which I believe addresses most, if not all, of the concerns with using x-editable with Meteor. It assumes you already have x-editable loaded some other way (either in a lib folder or through a package). It then makes a template in your .html files, and takes the same options x-editable does. If those parameters are reactive, the template will automatically update it. I will be updating my apps to use this instead of meteor-editable, whenever I get the time but it's available now.

@banglashi
Copy link
Member

Hi @dandv

Sorry for my late reply and thanks for tackling this issue. We changed to using hallojs on our application and will not continue maintaining the package. I was trying to find out how to actually remove this package and found this issue: oortcloud/atmosphere#53
I did the meteor admin set-unmigrated arillo:meteor-x-editable

Any ideas how to that properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants