Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

Docs: avd-lab-guide.md - grammar and line number references #150

Closed
mjbear opened this issue Mar 25, 2024 · 4 comments
Closed

Docs: avd-lab-guide.md - grammar and line number references #150

mjbear opened this issue Mar 25, 2024 · 4 comments

Comments

@mjbear
Copy link
Contributor

mjbear commented Mar 25, 2024

Hello Arista Engineering people,

Along with #148 and #149...

There are two grammatical and content related items in avd-lab-guide.md I'd like to bring up for discussion.
Based on the outcome of our discussion I will submit a PR to cover the approved items. Thank you.

  1. Change "Login to" to "Log into"

  2. The line numbers no longer exactly correlate. Should the line number reference be updated or changed to a relative statement?

  3. Similar to item 2, the line number is no longer accurate.

@JulioPDX
Copy link
Collaborator

Oh wow, I love your appreciation for good grammar. Login, log into, log in. Please go ahead and submit a PR for all of these items. I messed up the line numbering when I added the mlag config portions for same subnet.

@mjbear
Copy link
Contributor Author

mjbear commented Mar 26, 2024

My school grammar teachers left a mark on me, haha.

All good. If the line numbers continue to change we might consider referencing the line based on the relative position.

Examples:

  • Below the section - group: RACK2
  • in between the RACK2 section and Underlay Routing Protocol

@mjbear
Copy link
Contributor Author

mjbear commented Mar 26, 2024

Submitted PR #152

@JulioPDX
Copy link
Collaborator

Fixed in #152

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants