Bootstrap without docker v2 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabberyabber
reviewed
Sep 9, 2024
yabberyabber
approved these changes
Sep 9, 2024
With this change we bootstrap the workspace creation environment using a centos rootfs rather than pulling down a docker container. This has the following benefits: - docker and golang are no longer in the dependency set which should result in less cache churn - we no longer need a finalizer to set up yum repos --- creating these files in their own snapshot and overlaying it makes it much more cache-friendly and avoids us needing to mount the whole workspace in a tmpfs in order to let the finalizer run - we can check the content hash of the thing we download (in theory we trust quay.io to not change their docker image tags, but we have no way of checking this) - The artifactory URL can now be overridden via cluster config -- although the default value of artifactory.infra.corp.arista.io is preserved It does add a bit of complexity that we start with a centos container to bootstrap an alma container. However I don't think this is really an issue as the content that we are installing comes from our internal alma repositories. The only thing we are using centos for is to run dnf and resolve/install dependencies into our alma images.
Address Snaipe's comments:
- Elaborate on the description for bootstrap image
- Compare checksums wrt to a file.
- Combine bootstrap image generation sub images into a single one
to avoid caching the same thing multiple times, the steps are fast.
- Create mountpoints in the bootstrap image
Additional changes:
- CHECKSUM file, dnf/yum repo configuration and helper scripts are now
checked in to the repo as opposed to autogenerated in the build step to
make maintenance/upgrades easier and the barney.yaml a bit more
readable.
- Instead of downloading the tarball from the internet, download it
from a stashed copy in a local artifactory repo.
aajith-arista
force-pushed
the
aajith-eext-update
branch
from
80d98f1 to
370609d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have based on top of Andrew's PR here: #109
On top of his commit, I've done a few things: