Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the commit messages:
The rpms-* files all started with lines beginning with '#' which would
suggest a unix-script-style comment, but when the '#' was applied as an
inline comment, the install-rpms script treated that as part of the
package name, breaking it. Having those comments also meant that they
have to be stripped when processing.
This patch moves the content of those comments to a standalone README,
simplifying the sytnax of the file so it can be used as-is in the
install-rpms script.
The install-rpms accepted two non-optional "options" that ended up being
used the same way. There was some logic in that bash script that checked
and processed those options, and as it's typical of bash code, it had a
bug, where if the script was supplied with only one of the two
"options", the value of non-existent $extra_rpms_file, because it was
enclosed in double quotes, would be treated as an actual object (an
empty string), thus making the following code:
iterate over an empty "$file" blocking awk.
Because the only thing that this script did was to install RPMs
specified by text files, this patch changes it to do exactly that
without any error-prone bash logic.