SHA-256 hash support for unverified upstream sources #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishk-arista
force-pushed
the
manishk-upstreamSrc-sha
branch
from
fb5e905 to
6b33125
Compare
manith-arista
requested changes
Dec 16, 2024
manishk-arista
force-pushed
the
manishk-upstreamSrc-sha
branch
2 times, most recently
from
1a76c05 to
3ec6eb1
Compare
manishk-arista
force-pushed
the
manishk-upstreamSrc-sha
branch
from
3ec6eb1 to
a181955
Compare
| @@ -42,3 +42,12 @@ func TestMatchTarballSignature(t *testing.T) { | |||
| t.Log("Test tarball Signatue Match") | |||
| testTarballSig(t, "matchTarball") | |||
| } | |||
|
|
|||
| func TestUpstreamSourcesSHA256Hash(t *testing.T) { | |||
There was a problem hiding this comment.
Also add a test case where sha256 check fails.
util/util.go
Outdated
| func GenerateSha256Hash(filePath string) (string, error) { | ||
| file, err := os.Open(filePath) | ||
| if err != nil { | ||
| return "", fmt.Errorf("errored with %s while creating file", |
There was a problem hiding this comment.
fnt.Errorf( "%sGenerateSha256Hash: errored out with '%s',
errPrefix, err )
| @@ -0,0 +1,16 @@ | |||
| --- | |||
There was a problem hiding this comment.
Rename dir as upstream-hash-check-good
Also add a bad eext.yaml case under upstream-hash-check-bad
There was a problem hiding this comment.
present test case is checking for bad SHA256 hash
manishk-arista
force-pushed
the
manishk-upstreamSrc-sha
branch
from
a181955 to
65476af
Compare
Unverified upstream sources (those with `skip-check: true`) are inherently risky as they lack a verification method. Any changes to these sources could go undetected. To address this, we now calculate and store the SHA-256 hash of unverified sources. This hash is added to the `eext.yaml` file under the `src-sha256-hash` field. During the `create-srpm` command, the hash in `eext.yaml` will be compared with the hash of the downloaded sources.
manishk-arista
force-pushed
the
manishk-upstreamSrc-sha
branch
from
65476af to
7ca1e86
Compare
| @@ -131,6 +131,7 @@ type UpstreamSrc struct { | |||
| FullURL string `yaml:"full-url"` | |||
| GitBundle GitBundle `yaml:"git"` | |||
| Signature Signature `yaml:"signature"` | |||
| Sha256 string `yaml:"Sha256"` | |||
There was a problem hiding this comment.
Shall we go with sha256 in the yaml file? All other fields follow lowercase convention.
| @@ -50,6 +50,19 @@ func (bldr *srpmBuilder) getUpstreamSourceForOthers(upstreamSrcFromManifest mani | |||
| } | |||
| bldr.log("downloaded") | |||
|
|
|||
| if upstreamSrcFromManifest.Sha256 != "" { | |||
There was a problem hiding this comment.
This logic can be moved to a separate function. This will help you write test cases specifically for success/fail of signature check, instead of running create-srpm command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unverified upstream sources (those with
skip-check: true) are inherently risky as they lack a verification method. Any changes to these sources could go undetected. To address this, we now calculate and store the SHA-256 hash of unverified sources. This hash is added to theeext.yamlfile under thesrc-sha256-hashfield. During thecreate-srpmcommand, the hash ineext.yamlwill be compared with the hash of the downloaded sources.