Introduce arizona.erl and move (opaque) types inside it
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As "opaque" We'll later add setters, getters and more interface definition to module `arizona` The TODO was turned into an issue on GitHub
When trying to implement -spec(_).s for arizona_example
I came across some issues I overcame by changes to
arizona:
1. parse_str can only return {ok, _}, so we remove that
obstacle because of opacity (the macro is now a one liner)
2. arizona_socket:assign/_ was separated into get/put, for opacity
3. types were moved to more appropriate modules where they could
be easily used as opaques (this is most likely not the final
interface, but a step in between)
4. we added put/get_macro functions due to opacity constraints
5. we now force ARIZONA_LIVEVIEW to take Macros in
(otherwise this was a hidden hack)
6. we also spec'ed some stuff that's being used
(developed using _checkouts/)
Closed
paulo-ferraz-oliveira
added a commit
to arizona-framework/arizona_example
that referenced
this pull request
Jun 27, 2024
Expects a recent pull request to be merged: arizona-framework/arizona#104
2 tasks
|
Unresolved conversations are simply explanations, so I am giving myself the right to resolve them and move forward to merge arizona-framework/arizona_example#9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We'll later add setters, getters and more interface definition to module
arizona. This is just a minor first step to understand how consumption would happen next toarizona_example.The TODO was turned into an issue on GitHub.
Further considerations
When trying to use the new types in
arizona_exampleI had to overcome a few obstacles. I'll look at the changed files and try to "review" on some of the decisions, if warranted.