Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -spec(_).s #9

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Fix -spec(_).s #9

merged 3 commits into from
Jun 28, 2024

Conversation

paulo-ferraz-oliveira
Copy link
Member

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Jun 27, 2024

Description

Closes #8.

This depends on arizona-framework/arizona#104, so we'll have to re-run CI later.

But the changes are already Ok to get a sense of shape and what we want with Arizona consumption.

williamthome
williamthome previously approved these changes Jun 28, 2024
@williamthome
Copy link
Member

Hmm, arizona-framework/arizona#104 has been merged, but CI is still failing. Is it a cache bug? Or am I missing something?

@paulo-ferraz-oliveira
Copy link
Member Author

paulo-ferraz-oliveira commented Jun 28, 2024

It's not a cache bug. I either forget to push something or changed something last minute. I'll look at it 😄

Edit: actually, it might be a cache bug, since we're not keeping rebar.lock so the references didn't change.

1. we're not using rebar.lock so it should be part of the key
2. we're always going "bleeding edge", so we shouldn't cache deps
Copy link
Member

@williamthome williamthome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐

@williamthome williamthome merged commit c4d1590 into main Jun 28, 2024
3 checks passed
@williamthome williamthome deleted the fix/specs branch June 28, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pursue erl_opt warn_missing_spec later
2 participants