Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
  • Loading branch information
mmagician and Pratyush authored Sep 29, 2023
1 parent 8c82864 commit afd0709
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -358,16 +358,17 @@ pub trait PolynomialCommitment<F: PrimeField, P: Polynomial<F>, S: Cryptographic

let poly_query_set = lc_query_set_to_poly_query_set(lc_s.values().copied(), eqn_query_set);
let sorted_by_poly_and_query_label: BTreeSet<_> = poly_query_set
.iter()
.map(|(poly_label, v)| ((poly_label.clone(), v.1.clone()), v.0.clone()))
.clone()
.into_iter()
.map(|(poly_label, v)| ((poly_label.clone(), v.1), v.0))
.collect();

let poly_evals = Evaluations::from_iter(
sorted_by_poly_and_query_label

Check failure on line 367 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Check no_std

expected `[closure@lib.rs:370:22]` to be a closure that returns `((String, _), _)`, but it returns `((&String, &<P as Polynomial<F>>::Point), F)`

Check failure on line 367 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (stable)

expected `[closure@lib.rs:370:22]` to be a closure that returns `((String, _), _)`, but it returns `((&String, &<P as Polynomial<F>>::Point), F)`

Check failure on line 367 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (stable)

expected `[closure@lib.rs:370:22]` to be a closure that returns `((String, _), _)`, but it returns `((&String, &<P as Polynomial<F>>::Point), F)`

Check failure on line 367 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (nightly)

expected `{closure@lib.rs:370:22}` to be a closure that returns `((String, _), _)`, but it returns `((&String, &<P as Polynomial<F>>::Point), F)`
.iter()
.zip(evals.clone().unwrap())
.map(|(((poly_label, point), _query_label), eval)| {
((poly_label.clone(), point.clone()), eval)
((poly_label, point), eval)
}),
);

Expand Down

0 comments on commit afd0709

Please sign in to comment.