Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialize traits to LabeledCommitment #122

Closed
wants to merge 2 commits into from

Conversation

TakodaS
Copy link

@TakodaS TakodaS commented Sep 12, 2023

Description

Added CanonicalSerialize/Deserialize traits to the LabeledCommitment struct.

When poly-commit was updated to v0.4.0, the trait ToBytes was removed from LabeledCommit but the Serialization traits were not added.

Blocks arkworks-rs/marlin/pull/94 as LabeledCommit structs need to be absorbed by the sponge function to add entropy.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Pratyush
Copy link
Member

I think we shouldn't do this, as the labels exist purely at runtime; the versions absorbed into the sponge should be the unlabelled commitments.

@TakodaS
Copy link
Author

TakodaS commented Sep 19, 2023

I think we shouldn't do this, as the labels exist purely at runtime; the versions absorbed into the sponge should be the unlabelled commitments.

Having delved further into the marlin repo, I agree. Closing.

@TakodaS TakodaS closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants