Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default check combinations #123

Merged
merged 8 commits into from
Sep 29, 2023
Merged

Fix default check combinations #123

merged 8 commits into from
Sep 29, 2023

Commits on Sep 28, 2023

  1. temp: remove default impl of open/check combinations from marlin_pc

    @mmagician
    mmagician committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    57ac1ab View commit details
    Browse the repository at this point in the history

  2. fix check_combinations 

    fix combinations

remove prints

remove old comments
    @mmagician
    mmagician committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    dcffaec View commit details
    Browse the repository at this point in the history

  3. Revert "temp: remove default impl of open/check combinations from mar… 

    …lin_pc"

This reverts commit 25d4c8c.
    @mmagician
    mmagician committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a209c8c View commit details
    Browse the repository at this point in the history

  4. remove deprecated deny

    @mmagician
    mmagician committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8c82864 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
    @mmagician @Pratyush
    mmagician and Pratyush authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    afd0709 View commit details
    Browse the repository at this point in the history

  2. apply suggestions from code review 

    iter -> into_iter
    @mmagician
    mmagician committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    fe78ab8 View commit details
    Browse the repository at this point in the history

  3. format after fixes

    @mmagician
    mmagician committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    bff8255 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-default-check-combinations

    @mmagician
    mmagician authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e083199 View commit details
    Browse the repository at this point in the history