Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Group with AdditiveGroup for KZG, Marlin, and Sonic #126

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

autquis
Copy link
Contributor

@autquis autquis commented Sep 29, 2023

After the recent changes to ark-ec, there is no Group trait anymore. Currently, if we patch the dependency on crypto-primitive, everything is alright. However, if we use the feature merkle_tree from crypto-primitive, then poly-commit does not build. In this PR, I patched dependencies with their git version and changed Group to AdditiveGroup.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@autquis autquis requested a review from a team as a code owner September 29, 2023 12:21
@autquis autquis requested review from z-tech, mmagician and weikengchen and removed request for a team September 29, 2023 12:21
@mmagician
Copy link
Member

I believe you need to also patch r1cs-std, which is used in benches.

@mmagician mmagician added this pull request to the merge queue Sep 29, 2023
Merged via the queue into arkworks-rs:master with commit 3864531 Sep 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants