-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PreparedCommitment
& PreparedVerifierKey
don't belong on PolynomialCommitment
trait
#127
PreparedCommitment
& PreparedVerifierKey
don't belong on PolynomialCommitment
trait
#127
Conversation
cc @weikengchen IIRC these are useful for the constraint versions. |
Uhmm yes, sorry this was a bit quick of me to PR this. Indeed it is at least part of the trait definition for |
I'd be in favour of keeping the base How about introducing a supertrait
And modifying |
Ok, I think a cleaner solution, in 0435c2a, is to place the |
PreparedCommitment
& PreparedVerifierKey
were never usedPreparedCommitment
& PreparedVerifierKey
don't belong on PolynomialCommitment
trait
…ialCommitment` trait (arkworks-rs#127) * PreparedCommitment was never used * Remove PreparedVerifierKey * place `Prepared` types on `PCCheckVar` trait amend
Description
No trait method was even defined over these. I think if at some point someone implements some preprocessing, this can always be swapped out for the actual
Commitment
/VerifierKey
type and instead prepared there at the point of committing or setup - otherwise let's keep the traits simpler if we can.closes: #91
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer