Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #152 #153

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Resolve #152 #153

merged 4 commits into from
Oct 25, 2024

Conversation

skaunov
Copy link
Contributor

@skaunov skaunov commented Aug 27, 2024

Description

closes: #152

(Plus minor docs formatting.)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests - na
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

(Plus minor docs formatting.)
@skaunov skaunov requested a review from a team as a code owner August 27, 2024 12:16
@skaunov skaunov requested review from z-tech, Pratyush and weikengchen and removed request for a team August 27, 2024 12:16
@Pratyush
Copy link
Member

Could you please fix the failing CI? Then we can merge this PR!

@skaunov
Copy link
Contributor Author

skaunov commented Sep 19, 2024

I complied with a red lint, but it has nothing to do with the PR and issue; an absolutely unrelated thing out of the blue.

Feels like new lints were added in current Rust version and it fails due to these amendments in updated linter.

@Pratyush Pratyush added this pull request to the merge queue Oct 25, 2024
Merged via the queue into arkworks-rs:master with commit bbdb37e Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KZG10::open and friends visibility
2 participants