Constraints #47
Constraints #47
Conversation
weikengchen
force-pushed
the
constraints
branch
from
c3cfd3a
to
5271f40
Compare
|
Ok now that #46 is merged, this needs to be rebased atop master |
|
Yeet will do |
npwardberkeley
force-pushed
the
constraints
branch
from
5271f40
to
fdf1668
Compare
|
Rebased! |
|
oh lol it doesn't build. fixing... |
npwardberkeley
force-pushed
the
constraints
branch
from
4358263
to
8f17d50
Compare
|
No_std passes. |
|
I am going to add a feature about nonnative's density-optimization as well as do a final pass of this PR. |
|
Thanks, I think that'll make the implementation clearer as well. |
* Updates marlin constraints to latest LC representation * Cargo fmt
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
|
I will be back tomorrow to continue working on this. The rest is to apply previous code review comments. We might need to split the @howardwu This should reconcile with the upstream changes where the |
|
Would you like more reviews on this PR? If so, could there be a short description written up for what its doing? Happy to review then |
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu> Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com> Co-authored-by: Weikeng Chen <w.k@berkeley.edu> Co-authored-by: zhenfei <zhenfei.zhang@hotmail.com> Co-authored-by: Michael Rosenberg <micro@fastmail.com> Co-authored-by: Yuncong Hu <yuncong_hu@berkeley.edu>
| pub fn powers<'a>(&'a self) -> kzg10::Powers<'a, E> { | ||
| pub fn powers<'a>(&self) -> kzg10::Powers<'a, E> { | ||
| kzg10::Powers { | ||
| powers_of_g: self.powers.as_slice().into(), | ||
| powers_of_gamma_g: self.powers_of_gamma_g.as_slice().into(), |
There was a problem hiding this comment.
Why is this change necessary? We rely heavily on the non-cloning nature of this.
No description provided.