-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/map: Filter Page and Layout Update(booths, routes and symbol points) #103
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool! Good job this is awesome!
Overall I think everything works great I just want to discuss a few things:
- There seem to be a bug with the selection of booths (see video)
CleanShot.2024-10-24.at.09.10.49.mp4
- It it possible to make the logos a little smaller (right now I feel like they are overflowing quite a lot) (maybe even possible to introduce clustering?)
- Is it possible to increase the max zoom, you can't zoom in very far right now
- Filter button overlaps search
- Maybe it's just for me? But I can't scroll in this dropdown, can you? I have to drag the thumb at the right side
I also noticed that the page crashed if we couldn't find the exhibitor, that might be worth fixing, maybe we just exclude that exhibitor instead? What do you think? |
Hi I fixed most of the problems you mentioned above. @hampfh Also I didn't see the page crash when I try to search the exhibitor that is not exit (maybe provide a example that I can test?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🥳
Finish layout(booths, routes and points) for floor 2, 3 in Nymble. Align design with figma.
Implement filter page for highlighting booths later (local storage). Align design with figma.