Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/map: Filter Page and Layout Update(booths, routes and symbol points) #103

Merged
merged 20 commits into from
Nov 7, 2024

Conversation

AmiyaSX
Copy link
Contributor

@AmiyaSX AmiyaSX commented Oct 22, 2024

  • Finish layout(booths, routes and points) for floor 2, 3 in Nymble. Align design with figma.
    img_v3_02fu_cd38eed8-6538-4a48-ba1a-d387eead0a8g
    img_v3_02fu_a1d4ac78-c7e6-45ce-9340-001531037bdg

  • Implement filter page for highlighting booths later (local storage). Align design with figma.
    img_v3_02fu_9401aab2-005b-4129-9c92-becfbafbf79g
    img_v3_02fu_9209758f-7a02-4b03-aae9-1d16971dfd3g
    img_v3_02fu_51aeb7cf-265f-4dab-9950-ff389a9981ag

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
armada-nu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 6:17pm

Copy link
Member

@hampfh hampfh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! Good job this is awesome!

Overall I think everything works great I just want to discuss a few things:

  • There seem to be a bug with the selection of booths (see video)
CleanShot.2024-10-24.at.09.10.49.mp4
  • It it possible to make the logos a little smaller (right now I feel like they are overflowing quite a lot) (maybe even possible to introduce clustering?)
  • Is it possible to increase the max zoom, you can't zoom in very far right now
  • Filter button overlaps search
    CleanShot 2024-10-24 at 09 13 37
  • Maybe it's just for me? But I can't scroll in this dropdown, can you? I have to drag the thumb at the right side
    CleanShot 2024-10-24 at 09 14 34

@hampfh
Copy link
Member

hampfh commented Oct 24, 2024

I also noticed that the page crashed if we couldn't find the exhibitor, that might be worth fixing, maybe we just exclude that exhibitor instead? What do you think?

@AmiyaSX
Copy link
Contributor Author

AmiyaSX commented Oct 26, 2024

Hi I fixed most of the problems you mentioned above. @hampfh
For the filter icon overlapping with the search bar, we will refactor the sidebar(probably remove it and only keep a search input box there) so the filter icon will be that place, but right now I moved it to the right.

Also I didn't see the page crash when I try to search the exhibitor that is not exit (maybe provide a example that I can test?)

@AmiyaSX AmiyaSX closed this Oct 26, 2024
@AmiyaSX AmiyaSX reopened this Oct 26, 2024
Copy link
Member

@hampfh hampfh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🥳

@AmiyaSX AmiyaSX merged commit 861ef00 into main Nov 7, 2024
6 checks passed
@AmiyaSX AmiyaSX deleted the feat/map branch November 7, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants