Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standardize ci #279

Merged
merged 4 commits into from
Jul 13, 2023
Merged

feat: standardize ci #279

merged 4 commits into from
Jul 13, 2023

Conversation

dejanzele
Copy link
Member

@dejanzele dejanzele commented Jul 13, 2023

┆Issue is synchronized with this Jira Task by Unito

@dejanzele dejanzele requested a review from ClifHouck July 13, 2023 13:19
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d83148e) 84.17% compared to head (2d763de) 84.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files          15       15           
  Lines        3437     3437           
=======================================
  Hits         2893     2893           
  Misses        381      381           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? It seems to be a question in armada if we want this check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it still serves a purpose as a static code checker

Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we actually want codeql but we can remove it if we don't want it.

@dejanzele dejanzele merged commit 8f9a619 into armadaproject:main Jul 13, 2023
@dejanzele dejanzele deleted the feat/new-ci branch July 13, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants