-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add better guides for quickstart #292
feat: add better guides for quickstart #292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 84.19% 84.19% -0.01%
==========================================
Files 15 15
Lines 3461 3441 -20
==========================================
- Hits 2914 2897 -17
+ Misses 383 381 -2
+ Partials 164 163 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove references to Kubecon from this so its more evergreen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw a typo, but it's not a deal-breaker. I agree that the KubeCon references should probably be removed.
Note that Lookout V1 images are no longer being built, so it's good that this PR doesn't update to latest versions of the images. I have a bunch of changes to remove all references to Lookout V1, and update to latest numbered versions of all images, but that can wait until after this PR is merged.
55b3782
to
48144a2
Compare
48144a2
to
40fe75a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.