Fix flakey tests in getjobs_test + improve JobRuntime tests (#3654)

Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
armadaproject · Jun 5, 2024 · 0785656 · 0785656
1 parent 05b211a
commit 0785656
Show file tree

Hide file tree

Showing 2 changed files with 121 additions and 110 deletions.
diff --git a/internal/lookoutv2/repository/getjobs.go b/internal/lookoutv2/repository/getjobs.go
@@ -23,6 +23,7 @@ type GetJobsRepository interface {
 type SqlGetJobsRepository struct {
 	db            *pgxpool.Pool
 	lookoutTables *LookoutTables
+	clock         clock.Clock
 }
 
 type GetJobsResult struct {
@@ -54,6 +55,7 @@ func NewSqlGetJobsRepository(db *pgxpool.Pool) *SqlGetJobsRepository {
 	return &SqlGetJobsRepository{
 		db:            db,
 		lookoutTables: NewTables(),
+		clock:         clock.RealClock{},
 	}
 }
 
@@ -121,7 +123,7 @@ func (r *SqlGetJobsRepository) getJobs(ctx *armadacontext.Context, filters []*mo
 				job.Node = lastRun.Node
 				job.Cluster = lastRun.Cluster
 				job.ExitCode = lastRun.ExitCode
-				job.RuntimeSeconds = calculateJobRuntime(lastRun.Started, lastRun.Finished, clock.RealClock{})
+				job.RuntimeSeconds = calculateJobRuntime(lastRun.Started, lastRun.Finished, r.clock)
 			}
 			jobs = append(jobs, job)
 		}