Skip to content

Commit

Permalink
Add missing EventSequence_Event_JobRequeued cases (#2886)
Browse files Browse the repository at this point in the history
* Update conversions.go

* Update instructions.go

* Update conversions.go
  • Loading branch information
severinson authored Aug 16, 2023
1 parent 19a6858 commit 969cf19
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 3 additions & 2 deletions internal/armada/repository/apimessages/conversions.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,12 @@ func FromEventSequence(es *armadaevents.EventSequence) ([]*api.EventMessage, err
case *armadaevents.EventSequence_Event_ReprioritiseJobSet,
*armadaevents.EventSequence_Event_CancelJobSet,
*armadaevents.EventSequence_Event_JobRunSucceeded,
*armadaevents.EventSequence_Event_JobRequeued,
*armadaevents.EventSequence_Event_PartitionMarker:
// These events have no api analog right now, so we ignore
log.Debugf("Ignoring event")
log.Debugf("ignoring event type %T", esEvent)
default:
log.Warnf("Unknown event type: %T", esEvent)
log.Warnf("unknown event type: %T", esEvent)
convertedEvents = nil
}
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions internal/lookoutingester/instructions/instructions.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ func (c *InstructionConverter) convertSequence(es *armadaevents.EventSequence, u
err = c.handleJobRunPreempted(*event.Created, event.GetJobRunPreempted(), update)
case *armadaevents.EventSequence_Event_CancelJob,
*armadaevents.EventSequence_Event_JobRunLeased,
*armadaevents.EventSequence_Event_JobRequeued,
*armadaevents.EventSequence_Event_ReprioritiseJobSet,
*armadaevents.EventSequence_Event_CancelJobSet,
*armadaevents.EventSequence_Event_ResourceUtilisation,
Expand Down

0 comments on commit 969cf19

Please sign in to comment.