Return error if no longer leader when publishing (#3794)

Signed-off-by: Chris Martin <chris@cmartinit.co.uk> Co-authored-by: Chris Martin <chris@cmartinit.co.uk>
armadaproject · Jul 18, 2024 · a6cac13 · a6cac13
1 parent 68dcc3e
commit a6cac13
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/internal/scheduler/publisher.go b/internal/scheduler/publisher.go
@@ -125,7 +125,7 @@ func (p *PulsarPublisher) PublishMessages(ctx *armadacontext.Context, events []*
 			return errors.New("One or more messages failed to send to Pulsar")
 		}
 	} else {
-		ctx.Debugf("No longer leader so not publishing")
+		return errors.New("Failed to publish as no longer leader")
 	}
 	return nil
 }

diff --git a/internal/scheduler/publisher_test.go b/internal/scheduler/publisher_test.go
@@ -53,6 +53,7 @@ func TestPulsarPublisher_TestPublish(t *testing.T) {
 		"Don't publish if not leader": {
 			amLeader:               false,
 			numSuccessfulPublishes: math.MaxInt,
+			expectedError:          true,
 			eventSequences: []*armadaevents.EventSequence{
 				{
 					JobSetName: "jobset1",