From b83c562e23bc33703835c0d8ef7f84b3e75694b9 Mon Sep 17 00:00:00 2001 From: Aviral Singh Date: Fri, 28 Jul 2023 13:03:11 +0530 Subject: [PATCH] Feat(update): Testing and adding scenarios for golangci-lint --- .github/workflows/lint.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 32faacfbf5b..c4c3152c141 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -47,8 +47,6 @@ jobs: go-lint: name: Lint Go runs-on: ubuntu-22.04 - env: - LINT_RESULTS: "" steps: - name: Adding markdown run: echo '### Lint Go ✨' >> $GITHUB_STEP_SUMMARY @@ -80,6 +78,7 @@ jobs: run: | echo "- ✔️ Checked out the repository" >> $GITHUB_STEP_SUMMARY echo "- ✔️ Set up Go with version 1.20 and cached dependencies" >> $GITHUB_STEP_SUMMARY + if [ -n "$LINT_RESULTS" ]; then echo "- ❌ Go lint check failed" >> $GITHUB_STEP_SUMMARY echo "::error::Linting issues found. Check the details below." >> $GITHUB_STEP_SUMMARY @@ -87,7 +86,6 @@ jobs: exit 1 else echo "- ✔️ Go lint check passed" >> $GITHUB_STEP_SUMMARY - echo "::warning::No linting issues found." >> $GITHUB_STEP_SUMMARY fi continue-on-error: true if: always()