-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix release ci #2589
feat: fix release ci #2589
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2589 +/- ##
===========================================
+ Coverage 16.07% 34.38% +18.30%
===========================================
Files 159 112 -47
Lines 12490 3467 -9023
Branches 470 470
===========================================
- Hits 2008 1192 -816
+ Misses 10320 2192 -8128
+ Partials 162 83 -79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…o feat/release-ci-fix
Co-authored-by: Albin Severinson <albin@severinson.org> Co-authored-by: JamesMurkin <jamesmurkin@hotmail.com> Co-authored-by: Carlo Camurri <carlo.camurri98@gmail.com> Co-authored-by: Noah Held <41909795+zuqq@users.noreply.github.com> Co-authored-by: Rich Scott <rich@gr-oss.io> Co-authored-by: Jay Faulkner <jay@jvf.cc> Co-authored-by: Adam McArthur <46480158+Sharpz7@users.noreply.github.com> Co-authored-by: Kevin Hannon <kannon1992@gmail.com>
…o feat/release-ci-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
could you please post links to a release and a release-rc run on your fork? (you'll need these changes to be in your default branch for it to work)
Fixes #
Special notes for your reviewer:
┆Issue is synchronized with this Jira Task by Unito