-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new test workflow #2602
Merged
dejanzele
merged 25 commits into
armadaproject:master
from
dejanzele:feat/test-workflow
Jun 29, 2023
Merged
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
23b7ed1
add new test workflow
dejanzele 9f6acce
fix integration test target
dejanzele ec1aebd
fix unit test filter
dejanzele c808cfa
exclude jobservice test
dejanzele b790921
Merge branch 'master' into feat/test-workflow
kannon92 60b75de
add lint workflow
dejanzele b6560b5
Merge branch 'master' into feat/test-workflow
dejanzele f46166a
Merge branch 'feat/test-workflow' of github.com:dejanzele/armada into…
dejanzele 4d4082b
remove branches condition for test workflow on pr
dejanzele 325580b
Merge branch 'master' into feat/test-workflow
dejanzele 8984404
add aggregate workflow for CI
dejanzele a062acb
Merge branch 'feat/test-workflow' of github.com:dejanzele/armada into…
dejanzele be1ca4d
make test job after lint job
dejanzele 0ef06c0
add codeql job to ci
dejanzele 7ff9ec3
fix permissions in ci workflow
dejanzele 4535fc7
make codeql job run after lint job
dejanzele 5fb890f
remove needs from ci workflow jobs
dejanzele 397b126
run job on ubuntu 22.04
dejanzele dcea1da
move ts workflows to ci workflow
dejanzele 9278fdf
rename jobs in ci workflow
dejanzele 18c2e31
remove obsolete workflows
dejanzele 1050e31
add junit report for ts tests
dejanzele ae97e4a
Merge branch 'master' into feat/test-workflow
dejanzele 38ed669
Merge branch 'master' into feat/test-workflow
dejanzele ddd5aeb
Merge branch 'master' into feat/test-workflow
dejanzele File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
name: CI | ||
|
||
on: | ||
push: | ||
branches-ignore: | ||
- gh-pages | ||
pull_request: | ||
branches-ignore: | ||
- gh-pages | ||
schedule: | ||
# Run daily at 01:34, so we get notified if CI is broken before a pull request | ||
# is submitted. | ||
- cron: "34 1 * * *" | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
permissions: | ||
contents: read | ||
pull-requests: read | ||
checks: write | ||
actions: read | ||
security-events: write | ||
|
||
jobs: | ||
lint: | ||
uses: ./.github/workflows/lint.yml | ||
codeql: | ||
uses: ./.github/workflows/codeql-analysis.yml | ||
test: | ||
uses: ./.github/workflows/test.yml | ||
# Virtual job that can be configured as a required check before a PR can be merged. | ||
all-required-checks-done: | ||
name: All required checks done | ||
needs: | ||
- lint | ||
- codeql | ||
- test | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- run: | | ||
echo "All required checks done" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
name: "Lint" | ||
|
||
on: | ||
workflow_call: | ||
|
||
permissions: | ||
contents: read | ||
pull-requests: read | ||
|
||
jobs: | ||
ts-lint: | ||
# TODO(JayF): Determine what nodejs versions we target, and setup matrix-based testing similar to what we do for go | ||
name: Lint TypeScript | ||
runs-on: ubuntu-22.04 | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
|
||
- name: Setup Node | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: 16.14.2 | ||
cache: yarn | ||
cache-dependency-path: ./internal/lookout/ui/yarn.lock | ||
|
||
- name: Check TypeScript formatting | ||
run: | | ||
yarn install --frozen-lockfile && yarn run fmt || exit 1 | ||
exit $(git status -s -uno | wc -l) | ||
working-directory: ./internal/lookout/ui | ||
|
||
go-lint: | ||
name: Lint Go | ||
runs-on: ubuntu-22.04 | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
|
||
- name: Setup Golang with Cache | ||
uses: magnetikonline/action-golang-cache@v4 | ||
with: | ||
go-version: "1.20" | ||
|
||
- name: Lint using golangci-lint | ||
uses: golangci/golangci-lint-action@v3 | ||
with: | ||
skip-pkg-cache: true | ||
skip-build-cache: true | ||
version: v1.52.2 | ||
only-new-issues: true | ||
args: --timeout=10m --issues-exit-code=1 --sort-results ./... |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for this exact time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, random