Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup in lease.go #2603

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Conversation

severinson
Copy link
Contributor

@severinson severinson commented Jun 23, 2023

┆Issue is synchronized with this Jira Task by Unito

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 40.66% and project coverage change: +0.01 🎉

Comparison is base (807569f) 58.59% compared to head (1287c11) 58.60%.

❗ Current head 1287c11 differs from pull request most recent head 53dc9d6. Consider uploading reports for the commit 53dc9d6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2603      +/-   ##
==========================================
+ Coverage   58.59%   58.60%   +0.01%     
==========================================
  Files         236      236              
  Lines       30365    30357       -8     
==========================================
  Hits        17791    17791              
+ Misses      11207    11199       -8     
  Partials     1367     1367              
Flag Coverage Δ
armada-server 58.60% <40.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/armada/server/lease.go 7.56% <0.00%> (+0.08%) ⬆️
...ternal/executor/utilisation/cluster_utilisation.go 39.08% <0.00%> (ø)
internal/scheduler/common.go 75.77% <ø> (ø)
internal/scheduler/constraints/constraints.go 4.41% <0.00%> (ø)
internal/scheduler/preempting_queue_scheduler.go 65.14% <0.00%> (ø)
...nternal/scheduler/schedulerobjects/resourcelist.go 69.31% <68.42%> (ø)
internal/scheduler/context/context.go 34.26% <78.72%> (ø)
internal/scheduler/scheduling_algo.go 72.47% <94.73%> (ø)
internal/scheduler/reports.go 66.58% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severinson severinson enabled auto-merge (squash) June 23, 2023 10:18
@severinson severinson merged commit c6466da into master Jun 23, 2023
20 checks passed
@severinson severinson deleted the severinson/per-pc-limits-cleanup branch June 23, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants