Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise nodeSelector/annotations in Pulsar-backed scheduler #2610

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

severinson
Copy link
Contributor

@severinson severinson commented Jun 26, 2023

Necessary for preemption to work.

┆Issue is synchronized with this Jira Task by Unito

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.01 ⚠️

Comparison is base (df9ad30) 58.81% compared to head (30107e9) 58.81%.

❗ Current head 30107e9 differs from pull request most recent head 791956b. Consider uploading reports for the commit 791956b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2610      +/-   ##
==========================================
- Coverage   58.81%   58.81%   -0.01%     
==========================================
  Files         238      238              
  Lines       30542    30549       +7     
==========================================
+ Hits        17964    17968       +4     
- Misses      11209    11211       +2     
- Partials     1369     1370       +1     
Flag Coverage Δ
armada-server 58.81% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/scheduler/preempting_queue_scheduler.go 65.44% <66.66%> (-0.22%) ⬇️
internal/scheduler/jobdb/job.go 78.41% <72.72%> (-0.29%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severinson severinson merged commit 7542cd0 into master Jun 26, 2023
24 checks passed
@severinson severinson deleted the severinson/pulsar-preemption-fix branch June 26, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants