Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin docs python #2620

Merged
merged 6 commits into from
Jun 29, 2023
Merged

Pin docs python #2620

merged 6 commits into from
Jun 29, 2023

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Jun 28, 2023

Let's pin all dependencies for our client so we don't run into issues during CI.

Dependabot will upgrade these over time but we will know what upgrades break us and don't outside of CI.

┆Issue is synchronized with this Jira Task by Unito

@kannon92 kannon92 requested a review from jayofdoom June 28, 2023 17:45
@jayofdoom
Copy link
Contributor

Not the path I'd choose, and worth noting it would not have prevented the earlier failures, but this is a valid implementation of pinning the dependencies if that's what the armada community wants to do.

Copy link
Contributor

@jayofdoom jayofdoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's valid, even if I don't love the pattern of pinning deps.

Copy link
Contributor

@jayofdoom jayofdoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw something: Please leave my comment in so we know why we're pinning a transitive dependency. Maybe adjust it for correctness.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (03f6d04) 58.70% compared to head (79fc034) 58.70%.

❗ Current head 79fc034 differs from pull request most recent head 987db76. Consider uploading reports for the commit 987db76 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2620   +/-   ##
=======================================
  Coverage   58.70%   58.70%           
=======================================
  Files         238      238           
  Lines       30462    30462           
=======================================
  Hits        17883    17883           
  Misses      11230    11230           
  Partials     1349     1349           
Flag Coverage Δ
armada-server 58.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kannon92 kannon92 merged commit d49082d into master Jun 29, 2023
@kannon92 kannon92 deleted the pin-docs-python branch June 29, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants