-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin docs python #2620
Pin docs python #2620
Conversation
Not the path I'd choose, and worth noting it would not have prevented the earlier failures, but this is a valid implementation of pinning the dependencies if that's what the armada community wants to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's valid, even if I don't love the pattern of pinning deps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw something: Please leave my comment in so we know why we're pinning a transitive dependency. Maybe adjust it for correctness.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2620 +/- ##
=======================================
Coverage 58.70% 58.70%
=======================================
Files 238 238
Lines 30462 30462
=======================================
Hits 17883 17883
Misses 11230 11230
Partials 1349 1349
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Let's pin all dependencies for our client so we don't run into issues during CI.
Dependabot will upgrade these over time but we will know what upgrades break us and don't outside of CI.
┆Issue is synchronized with this Jira Task by Unito