Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mage target BuildPython to build python client. #2622

Merged

Conversation

ClifHouck
Copy link
Contributor

@ClifHouck ClifHouck commented Jun 29, 2023

Fixes #2556

Special notes for your reviewer:

┆Issue is synchronized with this Jira Task by Unito

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bfc629c) 16.21% compared to head (6307f19) 16.21%.

❗ Current head 6307f19 differs from pull request most recent head 2ade01d. Consider uploading reports for the commit 2ade01d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2622   +/-   ##
=======================================
  Coverage   16.21%   16.21%           
=======================================
  Files         160      160           
  Lines       12559    12559           
  Branches      487      487           
=======================================
  Hits         2037     2037           
  Misses      10353    10353           
  Partials      169      169           
Flag Coverage Δ
unittests 16.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we switch over to using this in our CI?

@Sharpz7
Copy link
Contributor

Sharpz7 commented Jun 30, 2023

Are we able to include the actual make command for the e2e tests in this work to??

i.e

tests-e2e-python: python
	docker run -v${PWD}/client/python:/code --workdir /code -e ARMADA_SERVER=server -e ARMADA_PORT=50051 --entrypoint python3 --network=kind armada-python-client-builder:latest -m pytest -v -s /code/tests/integration/test_no_auth.py

# To run integration tests with jobservice and such, we can run this command
# For now, let's just have it in rare cases that people need to test.
# You must have an existing cluster working to run this command.
.ONESHELL:
tests-e2e-airflow: airflow-operator build-docker-jobservice
	$(GO_CMD) go run cmd/armadactl/main.go create queue queue-a || true
	docker rm -f jobservice || true
	docker run -d --name jobservice --network=kind --mount 'type=bind,src=${PWD}/e2e,dst=/e2e' armada-jobservice run --config /e2e/setup/jobservice.yaml
	docker run -v ${PWD}/e2e:/e2e -v ${PWD}/third_party/airflow:/code --workdir /code -e ARMADA_SERVER=server -e ARMADA_PORT=50051 -e JOB_SERVICE_HOST=jobservice -e JOB_SERVICE_PORT=60003 --entrypoint python3 --network=kind armada-airflow-operator-builder:latest -m pytest -v -s /code/tests/integration/test_airflow_operator_logic.py
	docker rm -f jobservice
	```

Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @nitishchauhan0022 is working on the mage refactor he wanted to get this one merged. I think that is fine as we will switch over to using mage in that PR.

@kannon92 kannon92 merged commit a8284ce into armadaproject:master Jul 20, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python stuff into Localdev
3 participants