Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Databases Interfaces #2624

Merged
merged 7 commits into from
Jul 5, 2023
Merged

Conversation

em-r
Copy link
Contributor

@em-r em-r commented Jun 30, 2023

What type of PR is this?

Design Proposal.

What this PR does / why we need it:

This PR represents a proposal for defining database-agnostic interfaces that will assist in removing the tight coupling between Armada and the Postgres client pgx.

Which issue(s) this PR fixes:

Fixes #2121

Special notes for your reviewer:

This PR can be considered an in-progress PR, the proposed interfaces were verified against the existing Postgres implementation on Lookout, LookoutV2, and Scheduler. New changes might be introduced after completing the investigation of the remaining components (e.g. JobService)

┆Issue is synchronized with this Jira Task by Unito

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f128481) 16.07% compared to head (39c4a56) 16.07%.

❗ Current head 39c4a56 differs from pull request most recent head 9d5e789. Consider uploading reports for the commit 9d5e789 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2624   +/-   ##
=======================================
  Coverage   16.07%   16.07%           
=======================================
  Files         159      159           
  Lines       12490    12490           
  Branches      470      470           
=======================================
  Hits         2008     2008           
  Misses      10320    10320           
  Partials      162      162           
Flag Coverage Δ
unittests 16.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/design/database_interfaces.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannon92 kannon92 enabled auto-merge (squash) July 5, 2023 23:13
@kannon92 kannon92 merged commit 9a1ab98 into armadaproject:master Jul 5, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build interfaces around our postgres access
4 participants