-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL Databases Interfaces #2624
SQL Databases Interfaces #2624
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2624 +/- ##
=======================================
Coverage 16.07% 16.07%
=======================================
Files 159 159
Lines 12490 12490
Branches 470 470
=======================================
Hits 2008 2008
Misses 10320 10320
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Design Proposal.
What this PR does / why we need it:
This PR represents a proposal for defining database-agnostic interfaces that will assist in removing the tight coupling between Armada and the Postgres client
pgx
.Which issue(s) this PR fixes:
Fixes #2121
Special notes for your reviewer:
This PR can be considered an in-progress PR, the proposed interfaces were verified against the existing Postgres implementation on
Lookout
,LookoutV2
, andScheduler
. New changes might be introduced after completing the investigation of the remaining components (e.g. JobService)┆Issue is synchronized with this Jira Task by Unito