Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodedb.Node type #2625

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Add nodedb.Node type #2625

merged 1 commit into from
Jul 1, 2023

Conversation

zuqq
Copy link
Collaborator

@zuqq zuqq commented Jun 30, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (60944e7) 16.07% compared to head (1233522) 16.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2625   +/-   ##
=======================================
  Coverage   16.07%   16.07%           
=======================================
  Files         159      159           
  Lines       12490    12490           
  Branches      470      470           
=======================================
  Hits         2008     2008           
  Misses      10320    10320           
  Partials      162      162           
Flag Coverage Δ
unittests 16.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

}
labels[schedulerconfig.NodeIdLabel] = node.Id

totalResources := node.TotalResources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making a copy would be safer.

@severinson severinson merged commit 24fb052 into master Jul 1, 2023
31 checks passed
@severinson severinson deleted the zuqq/add-nodedb-node-type branch July 1, 2023 10:29
@zuqq zuqq mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants