Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a unit_test for on_kill() #2639

Closed

Conversation

sarthaksarthak9
Copy link
Contributor

@sarthaksarthak9 sarthaksarthak9 commented Jul 5, 2023

Fixes #

Special notes for your reviewer:

thank you for reviewing.

┆Issue is synchronized with this Jira Task by Unito

@sarthaksarthak9
Copy link
Contributor Author

@kannon92 pls review the changes.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -42.44 ⚠️

Comparison is base (8e761d3) 58.51% compared to head (0216ce3) 16.07%.

❗ Current head 0216ce3 differs from pull request most recent head b722141. Consider uploading reports for the commit b722141 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2639       +/-   ##
===========================================
- Coverage   58.51%   16.07%   -42.44%     
===========================================
  Files         235      159       -76     
  Lines       29639    12490    -17149     
  Branches        0      470      +470     
===========================================
- Hits        17342     2008    -15334     
+ Misses      10967    10320      -647     
+ Partials     1330      162     -1168     
Flag Coverage Δ
armada-server ?
unittests 16.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 369 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run ‘tox -e format-code’ and push those changes. CI is failing due to lack of formatting the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants