Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow version upgrade protoc & python #2748

Merged

Conversation

nitishchauhan0022
Copy link
Contributor

@nitishchauhan0022 nitishchauhan0022 commented Jul 25, 2023

Fixes #2594

Special notes for your reviewer:

┆Issue is synchronized with this Jira Task by Unito

@nitishchauhan0022
Copy link
Contributor Author

hey @kannon92, the version scheme of protobuf have changes last year. The version 21.0 is not the latest, should we go for the latest?
PTAL: https://protobuf.dev/news/2022-05-06/

Also the version in the go.mod is deprecated

image

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (31cb6fa) 47.07% compared to head (1509757) 47.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2748   +/-   ##
=======================================
  Coverage   47.07%   47.08%           
=======================================
  Files         391      391           
  Lines       43079    43079           
  Branches      487      487           
=======================================
+ Hits        20281    20282    +1     
+ Misses      21279    21278    -1     
  Partials     1519     1519           
Flag Coverage Δ
unittests 47.08% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kannon92
Copy link
Contributor

hey @kannon92, the version scheme of protobuf have changes last year. The version 21.0 is not the latest, should we go for the latest? PTAL: https://protobuf.dev/news/2022-05-06/

Also the version in the go.mod is deprecated

image

Please create a new ticket for that. I'm fine with including it in build but I'd like to do the version bump separately.

kannon92
kannon92 previously approved these changes Aug 10, 2023
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
@kannon92 kannon92 merged commit 22e2729 into armadaproject:master Aug 11, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated version of actions - python-client, actions.yml(python-tests) workflows
3 participants