-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow version upgrade protoc & python #2748
workflow version upgrade protoc & python #2748
Conversation
e4656ff
to
c81e0c2
Compare
hey @kannon92, the version scheme of protobuf have changes last year. The version 21.0 is not the latest, should we go for the latest? Also the version in the go.mod is deprecated |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2748 +/- ##
=======================================
Coverage 47.07% 47.08%
=======================================
Files 391 391
Lines 43079 43079
Branches 487 487
=======================================
+ Hits 20281 20282 +1
+ Misses 21279 21278 -1
Partials 1519 1519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please create a new ticket for that. I'm fine with including it in build but I'd like to do the version bump separately. |
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
cbc25c3
to
0392060
Compare
Fixes #2594
Special notes for your reviewer:
┆Issue is synchronized with this Jira Task by Unito