(flaky): unit test is flaky

[sarthaksarthak9]

Fixes #2863

Special notes for your reviewer:

┆Issue is synchronized with this Jira Task by Unito

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (98bcb76) 47.34% compared to head (9d9e472) 47.36%.
Report is 4 commits behind head on master.

❗ Current head 9d9e472 differs from pull request most recent head 0728f6a. Consider uploading reports for the commit 0728f6a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2898      +/-   ##
==========================================
+ Coverage   47.34%   47.36%   +0.02%     
==========================================
  Files         395      395              
  Lines       44045    44045              
  Branches      487      487              
==========================================
+ Hits        20854    20864      +10     
- Misses      21600    21602       +2     
+ Partials     1591     1579      -12     

Flag	Coverage Δ
unittests	47.36% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kannon92]

I think you need to pull in #2817 to reproduce this test failure actually.

Feel free to pull that update into this PR and verify that it passes with your change.

[sarthaksarthak9]

I think you need to pull in #2817 to reproduce this test failure actually.

Feel free to pull that update into this PR and verify that it passes with your change.

yah sure

[sarthaksarthak9]

I think you need to pull in #2817 to reproduce this test failure actually.

Feel free to pull that update into this PR and verify that it passes with your change.

Test: Result: Elapsed:
cancel_by_ids_1x10 SUCCESS 3.138102698s
failure_namespace SUCCESS 2.235140831s
failure_1x1 SUCCESS 40.949833655s
submit_fileshare_1x1 SUCCESS 34.040983221s
gang SUCCESS 42.760764042s
cancel_by_id_1x1 SUCCESS 3.139536149s
submit_1x1 SUCCESS 14.781153227s
priorityclass_default SUCCESS 18.189746618s
submit_2x3 SUCCESS 39.95960378s
failure_errimagepull SUCCESS 1m31.163410593s
failure_oom_1x1 SUCCESS 53.178964676s
service_headless SUCCESS 35.838284526s
cancel_by_set_1x1 SUCCESS 3.138119921s
ingress SUCCESS 37.647457063s
submit_random_clientid SUCCESS 37.147012671s

Ran 15 test(s) in 1m32.080266749s
Success: 15
Failure: 0

[kannon92]

The tests that are failing are unit tests not testsuite. mage tests.

If you get the merge conflicts fixed you can verify that this passes. The tests won't run because it says there is a merge issue.

[sarthaksarthak9]

The tests that are failing are unit tests not testsuite. mage tests.

If you get the merge conflicts fixed you can verify that this passes. The tests won't run because it says there is a merge issue.
I will check it out

[sarthaksarthak9]

The tests that are failing are unit tests not testsuite. mage tests.

If you get the merge conflicts fixed you can verify that this passes. The tests won't run because it says there is a merge issue.

and I by mistake merge older changes which causing merge conflicts

[Sharpz7]

@sarthaksarthak9 please fix the lint errors and I will get this merged

[sarthaksarthak9]

@sarthaksarthak9 please fix the lint errors and I will get this merged

ok

[Sharpz7]

mage lint-fix or make lint-fix @sarthaksarthak9 should do it.

[sarthaksarthak9]

mage lint-fix or make lint-fix @sarthaksarthak9 should do it.

okk

[sarthaksarthak9]

mage lint-fix or make lint-fix @sarthaksarthak9 should do it.

I am trying from yesterday but I am not able to resolved this ..

sarthak@:~/armada$ mage lint-fix
Unknown target specified: "lint-fix"

[Sharpz7]

@dejanzele @Mo-Fatah Do either of you know how to fix the tests on this PR?

[kannon92]

If you look at the go.mod job, you can get some help on this.

One needs to run go mod tidy and push those changes. I think our CI is saying that the go.mod is different from go.sum or whatever.

From that, I think most of it will come into place.

[sarthaksarthak9]

I think I did some mistake during resolving merge conflicts

[Mo-Fatah]

Apart from linting, the proto and go mod failures will be fixed with just go mod tidy

[Sharpz7]

@sarthaksarthak9 Sorry it is:

mage lintfix OR make lint-fix

[Mo-Fatah]

@sarthaksarthak9 can you run go mod tidy ? I think this will fix all the failed workflows including the lints. For some reasons I can't commit changes to your PR and I didn't want to open another PR since you already solved the problem here.

[sarthaksarthak9]

@sarthaksarthak9 can you run go mod tidy ? I think this will fix all the failed workflows including the lints. For some reasons I can't commit changes to your PR and I didn't want to open another PR since you already solved the problem here.

yah, sure

[sarthaksarthak9]

@Sharpz7 I messed up something , closing this pr . Pls review the new one #2914