Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Move website #3807

Closed
wants to merge 33 commits into from
Closed

Conversation

naskio
Copy link
Contributor

@naskio naskio commented Jul 22, 2024

What type of PR is this?

Improve website build and deployment process

What this PR does / why we need it:

  • Currently, we are using "Deploy from a branch" as source for building and deploying the website to GitHub Pages.
  • There's also the workflow "Deploy GH Pages" at .github/workflows/pages.yml which is responsible fo copying files from master to gh-pages branch.

Which issue(s) this PR fixes:

Fixes #3715

This PR includes the following:

  • Moving the website/ source code from the gh-pages branch to master under website/ folder.
  • Removing useless website/CNAME file (This file won't work with "GitHub Actions" as source, refer to the docs for more details)
  • Removing unused website/.circleci/ folder (CircleCI is not being used as you can see here)
  • Removing unneeded website/.mergify.yml file (Not needed because we won't use a branch anymore)
  • Renaming website/README.txt to website/README.md and convert to Markdown format (this would allow GitHub to display a formatted page)
  • Renaming docs/docs-readme.md to docs/README.md (This would allow GitHub to display a formatted page)
  • Update Jekyll _config.yml to exclude README.md, copy.sh, Gemfile, Gemfile.lock from output (For example, we won't have this file anymore https://armadaproject.io/Gemfile)

Special notes for your reviewer:

Once this PR is merged, we would also need to:

  • Set "Source" to "GitHub Actions" in "Settings > Pages > Build and deployment > Source".
  • Set "Custom domain" to armadaproject.io in "Settings > Pages > Build and deployment > Custom domain".
  • Get rid of the gh-pages branch (Optional).

Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
naskio added 16 commits July 22, 2024 14:03
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
Signed-off-by: Mehdi Nassim KHODJA <18899702+naskio@users.noreply.github.com>
@naskio naskio closed this Aug 1, 2024
@naskio
Copy link
Contributor Author

naskio commented Aug 1, 2024

Replaced by #3850

@naskio naskio changed the title Move website from gh-pages branch to master under website/ folder [CLOSED] Move website from gh-pages branch to master under website/ folder Aug 1, 2024
@naskio naskio changed the title [CLOSED] Move website from gh-pages branch to master under website/ folder [CLOSED] Move website Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Automatic deploy of GitHub Pages doesn't work due to required protection on branches
1 participant