Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preempted metrics #3951

Merged
merged 5 commits into from
Sep 21, 2024
Merged

Fix preempted metrics #3951

merged 5 commits into from
Sep 21, 2024

Conversation

d80tb7
Copy link
Collaborator

@d80tb7 d80tb7 commented Sep 15, 2024

This isn't an ideal solution but the state transition metrics stuff is pretty hairy. Basically:

  • Mark preemption time at the point of preemption
  • Manually store preemption metric as we do for leases

@d80tb7
Fix preempted metrics
04e26ed 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
fix comment
e74cec1 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
fix test
1c85c36 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
lint
be6a1a5 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7 d80tb7 merged commit 72f71dc into master Sep 21, 2024
28 checks passed
@d80tb7 d80tb7 deleted the f/chrisma/preempted-metrics branch September 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesMurkin JamesMurkin JamesMurkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d80tb7 @JamesMurkin