Improvements to Job Iteration #3957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
d80tb7
commented
Sep 20, 2024
d80tb7
commented
- Define Job and JobContext Iterators based on Go's new iterator syntax
- Define some iterator helper functions based on proposal: x/exp/xiter: new package with iterator adapters golang/go#61898. Hopefully similar functions should become part of the go stdlib in a future go release and we can easily move to those when they become available.
- Modify Job Repository so that it becimes simply an inteface for looking up jobs and getting the JobIterator for a queue
…ma/better-job-interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.